Welcome to the FlexRadio Community! Please review the new Community Rules and other important new Community information on the Message Board.
Need the latest SmartSDR or 4O3A Genius Product Software?
SmartSDR v3.9.19 and the SmartSDR v3.9.19 Release Notes
SmartSDR v2.12.1 and the SmartSDR v2.12.1 Release Notes
The latest 4O3A Genius Product Software and Firmware
SmartSDR v3.9.19 and the SmartSDR v3.9.19 Release Notes
SmartSDR v2.12.1 and the SmartSDR v2.12.1 Release Notes
The latest 4O3A Genius Product Software and Firmware
If you are having a problem, please refer to the product documentation or check the Help Center for known solutions.
Need technical support from FlexRadio? It's as simple as Creating a HelpDesk ticket.
Need technical support from FlexRadio? It's as simple as Creating a HelpDesk ticket.
Typo in panadapter.cs (flexlib)

rfoust
Member ✭✭
Found a typo, I think RaisePropertyChanged should be RFGainStep instead of RFGainHigh in the snippet below:
private double _rf_gain_step; public double RFGainStep { get { return _rf_gain_step; } set { if (_rf_gain_step != value) { _rf_gain_step = value; RaisePropertyChanged("RFGainHigh"); } } }
0
Comments
-
It is a typo. Good catch! We'll get it fixed. Thanks.2
-
For reference, this is issue #1821.0
-
<total aside>
Can I just chime-in with some unsolicited advice? These names of the properties (the argument to RaisePropertyChanged) would ideally be constants, and not require the dev to type-in a string literal at each invocation. Eliminates any chance of typos making it into the released code. Also, it they were scoped correctly, the consumer of the API could use the same constants when consuming the events.
Sorry, it's the dev manager in me...
</total aside>
0 -
I agree with you and had the same concerns when we started using the ObservableObject class (which uses the INotifyProperty interface). This is the industry standard for binding WPF GUI components to C# libraries (see https://msdn.microsoft.com/en-us/library/system.componentmodel.inotifypropertychanged%28v=vs.110%29....). Aside from the string issue, it has really worked pretty well.0
-
As someone not familiar with dot net programming and C sharp, why not use a string constant and refactor the constants into a header file?0
-
Again, the INotifyProperty interface which uses the string based propertyName variables is the industry standard way of binding WPF GUI components to C# libraries -- especially if using the Model View ViewModel (MVVM) framework. I, personally, would rather take my licks with the standard that thousands of other developers are using rather than trying to roll my own and not have the support and documentation of millions of lines of code from which others have already learned.1
Leave a Comment
Categories
- All Categories
- 349 Community Topics
- 2.1K New Ideas
- 615 The Flea Market
- 8K Software
- 2 SmartSDR+
- 6.3K SmartSDR for Windows
- 173 SmartSDR for Maestro and M models
- 412 SmartSDR for Mac
- 267 SmartSDR for iOS
- 249 SmartSDR CAT
- 186 DAX
- 375 SmartSDR API
- 9.2K Radios and Accessories
- 22 Aurora
- 207 FLEX-8000 Signature Series
- 7.1K FLEX-6000 Signature Series
- 921 Maestro
- 53 FlexControl
- 860 FLEX Series (Legacy) Radios
- 894 Genius Products
- 455 Power Genius XL Amplifier
- 323 Tuner Genius XL
- 116 Antenna Genius
- 283 Shack Infrastructure
- 199 Networking
- 444 Remote Operation (SmartLink)
- 138 Contesting
- 754 Peripherals & Station Integration
- 139 Amateur Radio Interests
- 973 Third-Party Software