Welcome to the new FlexRadio Community! Please review the new Community Rules and other important new Community information on the Message Board.
Need the latest SmartSDR, Power Genius, Tuner Genius and Antenna Genius Software?
SmartSDR v3.7.4 and the SmartSDR v3.7.4 Release Notes | SmartSDR v2.12.1 and the SmartSDR v2.12.1 Release Notes
SmartSDR v1.12.1 and the SmartSDR v1.12.1 Release Notes
Power Genius XL Utility v3.8.8 and the Power Genius XL Release Notes v3.8.8
Tuner Genius XL Utility v1.2.11 and the Tuner Genius XL Release Notes v1.2.11
Antenna Genius Utility v4.1.8
SmartSDR v3.7.4 and the SmartSDR v3.7.4 Release Notes | SmartSDR v2.12.1 and the SmartSDR v2.12.1 Release Notes
SmartSDR v1.12.1 and the SmartSDR v1.12.1 Release Notes
Power Genius XL Utility v3.8.8 and the Power Genius XL Release Notes v3.8.8
Tuner Genius XL Utility v1.2.11 and the Tuner Genius XL Release Notes v1.2.11
Antenna Genius Utility v4.1.8
If you are having a problem, please refer to the product documentation or check the Help Center for known solutions.
Need technical support from FlexRadio? It's as simple as Creating a HelpDesk ticket.
Need technical support from FlexRadio? It's as simple as Creating a HelpDesk ticket.
Typo in panadapter.cs (flexlib)
Options
rfoust
Member ✭✭
Found a typo, I think RaisePropertyChanged should be RFGainStep instead of RFGainHigh in the snippet below:
private double _rf_gain_step; public double RFGainStep { get { return _rf_gain_step; } set { if (_rf_gain_step != value) { _rf_gain_step = value; RaisePropertyChanged("RFGainHigh"); } } }
0
Comments
-
It is a typo. Good catch! We'll get it fixed. Thanks.2
-
For reference, this is issue #1821.0
-
<total aside>
Can I just chime-in with some unsolicited advice? These names of the properties (the argument to RaisePropertyChanged) would ideally be constants, and not require the dev to type-in a string literal at each invocation. Eliminates any chance of typos making it into the released code. Also, it they were scoped correctly, the consumer of the API could use the same constants when consuming the events.
Sorry, it's the dev manager in me...
</total aside>
0 -
I agree with you and had the same concerns when we started using the ObservableObject class (which uses the INotifyProperty interface). This is the industry standard for binding WPF GUI components to C# libraries (see https://msdn.microsoft.com/en-us/library/system.componentmodel.inotifypropertychanged%28v=vs.110%29....). Aside from the string issue, it has really worked pretty well.0
-
As someone not familiar with dot net programming and C sharp, why not use a string constant and refactor the constants into a header file?0
-
Again, the INotifyProperty interface which uses the string based propertyName variables is the industry standard way of binding WPF GUI components to C# libraries -- especially if using the Model View ViewModel (MVVM) framework. I, personally, would rather take my licks with the standard that thousands of other developers are using rather than trying to roll my own and not have the support and documentation of millions of lines of code from which others have already learned.1
Leave a Comment
Categories
- All Categories
- 245 Community Topics
- 2.1K New Ideas
- 490 The Flea Market
- 7.4K Software
- 5.9K SmartSDR for Windows
- 135 SmartSDR for Maestro and M models
- 327 SmartSDR for Mac
- 243 SmartSDR for iOS
- 224 SmartSDR CAT
- 163 DAX
- 347 SmartSDR API
- 8.5K Radios and Accessories
- 6.9K FLEX-6000 Signature Series
- 768 Maestro
- 42 FlexControl
- 836 FLEX Series (Legacy) Radios
- 727 Genius Products
- 392 Power Genius XL Amplifier
- 251 Tuner Genius XL
- 84 Antenna Genius
- 222 Shack Infrastructure
- 149 Networking
- 370 Remote Operation (SmartLink)
- 118 Contesting
- 582 Peripherals & Station Integration
- 116 Amateur Radio Interests
- 811 Third-Party Software